Skip to content

Spelling python#10802

Merged
tausbn merged 53 commits intogithub:mainfrom
jsoref:spelling-python
Oct 17, 2022
Merged

Spelling python#10802
tausbn merged 53 commits intogithub:mainfrom
jsoref:spelling-python

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Oct 12, 2022

follow-up to #10743

@jsoref jsoref requested a review from a team as a code owner October 12, 2022 20:55
jsoref
jsoref commented Oct 12, 2022
View reviewed changes
Comment thread python/ql/lib/design.md Outdated
tausbn
tausbn previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change (that I've added as a suggestion, and will apply shortly), but otherwise this looks good to me. Thanks!

Comment thread python/ql/lib/design.md Outdated
@tausbn tausbn added ready-for-internal-ci no-change-note-required This PR does not need a change note labels Oct 13, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 13, 2022

QHelp previews:

@tausbn
Copy link
Copy Markdown
Contributor

tausbn commented Oct 13, 2022

Ah, some of the changes need to be synchronised across files. Specifically (in the context of this PR), each of the following sets of files are required to have the same content:

javascript/ql/lib/semmle/javascript/security/regexp/ExponentialBackTracking.qll
python/ql/lib/semmle/python/security/regexp/ExponentialBackTracking.qll
ruby/ql/lib/codeql/ruby/security/regexp/ExponentialBackTracking.qll
java/ql/lib/semmle/code/java/security/regexp/ExponentialBackTracking.qll

javascript/ql/lib/semmle/javascript/security/regexp/SuperlinearBackTracking.qll
python/ql/lib/semmle/python/security/regexp/SuperlinearBackTracking.qll
ruby/ql/lib/codeql/ruby/security/regexp/SuperlinearBackTracking.qll
java/ql/lib/semmle/code/java/security/regexp/SuperlinearBackTracking.qll

javascript/ql/lib/semmle/javascript/security/regexp/RegexpMatching.qll
python/ql/lib/semmle/python/security/regexp/RegexpMatching.qll
ruby/ql/lib/codeql/ruby/security/regexp/RegexpMatching.qll

javascript/ql/lib/semmle/javascript/security/BadTagFilterQuery.qll
python/ql/lib/semmle/python/security/BadTagFilterQuery.qll
ruby/ql/lib/codeql/ruby/security/BadTagFilterQuery.qll

The easiest way to fix this is probably to revert the changes in this PR that affect the above files, and then make a separate PR for all of those changes (across all the affected languages).

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Oct 13, 2022

Sounds good. I've already done that once for #10799.

Should I do them as one PR "common", or one PR per family (ExponentialBackTracking, ...)?

@tausbn
Copy link
Copy Markdown
Contributor

tausbn commented Oct 13, 2022

Should I do them as one PR "common", or one PR per family (ExponentialBackTracking, ...)?

I would just do them in one big PR. They're all somewhat related anyway.

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Oct 13, 2022

I've kicked them over to the ruby PR #10801. I'll drop them from here...

tausbn
tausbn previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

jsoref added 12 commits October 13, 2022 11:21
@jsoref
spelling: access
f2fee60 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: attribute
ac1c522 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: compatibility
e3b85b1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: connection
6e905ce 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: context
d648886 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: corresponding
3f74fa9 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: credentials
dc38300 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: cross
cce8a97 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: decide
9eaeafd 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: decorated
7b070ba 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: dispatcher
165514c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: distinguish
7fd7d9c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 22 commits October 13, 2022 11:21
@jsoref
spelling: processing
662c96e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: quadratic
7b019da 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: qualified
c02b6b3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: recommendation
7ad24f3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: recursion
441d535 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: representing
24f847a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: request
00cc333 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: resolve
76aa048 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: response
36bd186 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: restrictions
d1929ab 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: retrieval
eed0971 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: sanitize
ad7dc81 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: see https
bc339e4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: shortcuts
05e20a3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: something
33bc313 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: superfluous
887b49a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: synthesized
7ee24e5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: the
8669de5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: uninitialized
f19a5c4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: whether
5765a71 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: which
9fef7d4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: without
08f688d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
jsoref commented Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just tossed in a couple more.

I can kick them out if that's a problem.

Comment thread python/ql/lib/semmle/python/types/IgnoredAndApproximations.txt
tausbn
tausbn approved these changes Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll run the CI and then merge it. 👍

Comment thread python/ql/lib/semmle/python/types/IgnoredAndApproximations.txt
@tausbn tausbn merged commit fa2faeb into github:main Oct 17, 2022
@jsoref jsoref deleted the spelling-python branch October 18, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tausbn tausbn tausbn approved these changes

Assignees

No one assigned

Labels

documentation no-change-note-required This PR does not need a change note Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoref @tausbn @codeql-ci