Skip to content

Spelling ruby#10801

Merged
aibaars merged 23 commits intogithub:mainfrom
jsoref:spelling-ruby
Oct 13, 2022
Merged

Spelling ruby#10801
aibaars merged 23 commits intogithub:mainfrom
jsoref:spelling-ruby

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Oct 12, 2022

follow-up to #10743

per @aibaars, I'm including the changes for the handful of shared items in this PR.

@jsoref jsoref requested a review from a team as a code owner October 12, 2022 20:55
Copy link
Copy Markdown
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes. I think there is one grammatical mistake, but otherwise fine.

Comment thread ruby/ql/lib/codeql/ruby/security/BadTagFilterQuery.qll Outdated
@github-actions
Copy link
Copy Markdown
Contributor

QHelp previews:

@aibaars
Copy link
Copy Markdown
Contributor

aibaars commented Oct 13, 2022

@jsoref to fix the errors in the synchronized files job you can run:

python3 config/sync-files.py --latest

or if that doesn't do the right thing for some reason, you can run

python3 config/sync-files.py ./ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImplShared.qll
python3 config/sync-files.py ./ruby/ql/lib/codeql/ruby/security/BadTagFilterQuery.qll
python3 config/sync-files.py ./ruby/ql/lib/codeql/ruby/security/regexp/ExponentialBackTracking.qll
python3 config/sync-files.py ./ruby/ql/lib/codeql/ruby/security/regexp/RegexpMatching.qll
python3 config/sync-files.py ./ruby/ql/lib/codeql/ruby/security/regexp/SuperlinearBackTracking.qll

Note: you may also need to fix the following after sync'ing the ControlFlowGraphImplShared.qll file.

swift/ql/test/library-tests/controlflow/graph/Cfg.ql:  override string getOrderDisambuigation() {

@aibaars
Copy link
Copy Markdown
Contributor

aibaars commented Oct 13, 2022

The QL test error can be fixed by updating the expected output in ruby/ql/test/query-tests/experimental/manually-check-http-verb/ManuallyCheckHttpVerb.expected and replace mappting => mapping

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 11 commits October 13, 2022 10:56
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref mentioned this pull request Oct 13, 2022
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift 👍

@aibaars aibaars merged commit a327802 into github:main Oct 13, 2022
@jsoref jsoref deleted the spelling-ruby branch October 13, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants