ReDoS: Spelling nfautils#10799
Merged
erik-krogh merged 6 commits intogithub:mainfrom Oct 12, 2022
Merged
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
erik-krogh
reviewed
Oct 12, 2022
| */ | ||
| class EmptyPositiveSubPatttern extends RegExpSubPattern { | ||
| EmptyPositiveSubPatttern() { | ||
| class EmptyPositiveSubPattern extends RegExpSubPattern { |
Contributor
There was a problem hiding this comment.
Could you add this above? (In all copies of NfaUtils.qll).
/** DEPRECATED: Use `EmptyPositiveSubPattern` instead. */
deprecated class EmptyPositiveSubPatttern = EmptyPositiveSubPattern;
Contributor
There was a problem hiding this comment.
Also, it seems the code formatter check is failing.
Either autoformat using VSCode, or do codeql query format -i.
jsoref
commented
Oct 12, 2022
Comment on lines
-62
to
+63
| class EmptyPositiveSubPatttern extends RegExpSubPattern { | ||
| EmptyPositiveSubPatttern() { | ||
| class EmptyPositiveSubPattern extends RegExpSubPattern { | ||
| EmptyPositiveSubPattern() { |
Comment on lines
337
to
+340
| } | ||
|
|
||
| private string lowercaseLetter() { result = "abdcefghijklmnopqrstuvwxyz".charAt(_) } | ||
| private string lowercaseLetter() { result = "abcdefghijklmnopqrstuvwxyz".charAt(_) } |
250428c to
a2b0cf2
Compare
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
a2b0cf2 to
09c8a98
Compare
erik-krogh
approved these changes
Oct 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #10743