refactor: remove Unity.Collections package dependency#441
Merged
Conversation
0xFA11
commented
Jan 14, 2021
Comment on lines
-4
to
-6
| "references": [ | ||
| "GUID:e0cd26848372d4e5c891c569017e11f1" | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
this is Unity.Collections package's GUID
NoelStephensUnity
approved these changes
Jan 14, 2021
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
It is sad to see it go. Changes look like it will do the trick!
|
This needs a conversation. |
eb89cc2 to
fd74fd5
Compare
|
|
||
| namespace MLAPI.Tests | ||
| { | ||
| public class PlaceholderTests |
Contributor
There was a problem hiding this comment.
Did you mean to leave this in? Seems like either we would want to remove it, add some comments on why it's there or actually implement some tests
Contributor
Author
There was a problem hiding this comment.
yes, that was intentional. I commented a note inline indicating that.
mattwalsh-unity
suggested changes
Jan 20, 2021
Contributor
mattwalsh-unity
left a comment
There was a problem hiding this comment.
See comments on the testing module
mattwalsh-unity
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we're not using
DataStreamand Unity.Collections package dependency might hold us back targeting 2019.4 & 2020.x for MLAPI package release.Having said that, we might consider using NativeArray from UnityEngine.CoreModule and put in stream/reader/writer implementations into MLAPI side separately and independent from Unity.Collections package.