Skip to content

refactor: remove Unity.Collections package dependency #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xFA11 merged 4 commits into from
Jan 21, 2021
Merged

refactor: remove Unity.Collections package dependency #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a085992
refactor: remove Unity.Collections package dependency
0xFA11 Jan 14, 2021
fd74fd5
refactor: remove DataStreamTests
0xFA11 Jan 15, 2021
c701f7a
Merge branch 'develop' into remove-collections-dep
0xFA11 Jan 21, 2021
a549177
refactor: comment a note inline for future reference
0xFA11 Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
661 changes: 0 additions & 661 deletions com.unity.multiplayer.mlapi/Runtime/Serialization/DataStream.cs
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions com.unity.multiplayer.mlapi/Runtime/com.unity.multiplayer.mlapi.runtime.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"name": "Unity.Multiplayer.MLAPI.Runtime",
"rootNamespace": "MLAPI",
"references": [
"GUID:e0cd26848372d4e5c891c569017e11f1"
],
Comment on lines -4 to -6
Copy link
Copy Markdown
Contributor Author

@0xFA11 0xFA11 Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is Unity.Collections package's GUID

"references": [],
"includePlatforms": [],
"excludePlatforms": [],
"allowUnsafeCode": true,
Expand Down
189 changes: 0 additions & 189 deletions com.unity.multiplayer.mlapi/Tests/Editor/DataStreamTests.cs
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions com.unity.multiplayer.mlapi/Tests/Editor/DataStreamTests.cs.meta
View file
Open in desktop

This file was deleted.

15 changes: 15 additions & 0 deletions com.unity.multiplayer.mlapi/Tests/Editor/Placeholder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
using NUnit.Framework;

namespace MLAPI.Tests
{
public class PlaceholderTests
Copy link
Copy Markdown
Contributor

@mattwalsh-unity mattwalsh-unity Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this in? Seems like either we would want to remove it, add some comments on why it's there or actually implement some tests

Copy link
Copy Markdown
Contributor Author

@0xFA11 0xFA11 Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that was intentional. I commented a note inline indicating that.

{
[Test]
public void Foo()
{
// (JIRA) MTT-408: [Spike] Identify testing requirements
// We will move towards more and more automated tests soon.
// Let's keep this here for now, as a reminder :)
}
}
}
2 changes: 1 addition & 1 deletion .../Runtime/Serialization/DataStream.cs.meta → ...er.mlapi/Tests/Editor/Placeholder.cs.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions com.unity.multiplayer.mlapi/Tests/Editor/com.unity.mulitplayer.mlapi.editortest.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{
"name": "Unity.Multiplayer.MLAPI.EditorTests",
"references": [
"Unity.Collections",
"Unity.Mathematics",
"Unity.Multiplayer.MLAPI.Runtime"
],
"optionalUnityReferences": [
Expand All @@ -11,6 +9,5 @@
"includePlatforms": [
"Editor"
],
"excludePlatforms": [],
"allowUnsafeCode": true
"excludePlatforms": []
}
5 changes: 2 additions & 3 deletions com.unity.multiplayer.mlapi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"type": "library",
"hideInEditor": false,
"dependencies": {
"com.unity.nuget.mono-cecil": "1.10.1-preview.1",
"com.unity.collections": "0.9.0-preview.6"
"com.unity.nuget.mono-cecil": "1.10.1-preview.1"
}
}
}