ci: downgrade target unity version and remove windows platform target#443
ci: downgrade target unity version and remove windows platform target#443
Conversation
| { | ||
| using PooledBitStream copy = PooledBitStream.Get(); | ||
| do | ||
| using (var copy = PooledBitStream.Get()) |
There was a problem hiding this comment.
this using var declaration is C# 8.0 which is not supported on 2019.4 and 2020.1 @jeffreyrainy :)
but using (...) { ... } block is fine!
| # for validation | ||
| test_editors: | ||
| - 2020.2 | ||
| - 2019.4 |
There was a problem hiding this comment.
Target both? Or 2019.4, 2021.1, & trunk?
There was a problem hiding this comment.
just double-checking: 2020.1 or 2021.1?
| # Platforms that will be tested. The first entry in this array will also | ||
| # be used for validation | ||
| test_platforms: | ||
| - name: win |
There was a problem hiding this comment.
I'd either remove the platform from develop_pull_request_trigger target in project-test.yml OR just leave it there but change the github gates to not require that check to pass for PR merges. Doing it the way you have in this PR makes me nervous about losing coverage for newer versions on win platform.
| "hideInEditor": false, | ||
| "dependencies": { | ||
| "com.unity.nuget.mono-cecil": "1.10.1-preview.1", | ||
| "com.unity.collections": "0.14.0-preview.16" |
There was a problem hiding this comment.
I think we need to have a conversation about this one ASAP, but O.K. for now.
|
This PR is no longer needed — PR #447 supersedes this. |
As per @JesseOlmer's suggestion, this PR is an attempt to downgrade MLAPI package targeting Unity 2019.4 and removing Windows platform target temporarily. An ILPP issue on 2019.4 and 2020.1 that's specific to Windows platform is holding us back but while working on that issue, we might be able to keep working on 2019.4 target.