Merged
Conversation
Ruby keyword arguments are represented differently than positional arguments in the MaD format: they are represented as `Method[key:]`. The framework endpoints query also returns the name as `key:`, so we can detect these and format them as such.
37cc08a to
5f2a32a
Compare
norascheuch
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
Argument[key:]for Ruby. These are used for keyword arguments (in e.g.def method(key:).The query will return keyword arguments as
key:.Based on #3052
Checklist
ready-for-doc-reviewlabel there.