Extract creation of method argument options to languages#3052
Merged
Conversation
This moves the creation of possible method argument options from the view to the languages. This allows differentiating between the languages, for example by using `Argument[self]` for Ruby instead of `Argument[this]`.
e433f1e to
b348356
Compare
3 tasks
norascheuch
approved these changes
Nov 6, 2023
Contributor
norascheuch
left a comment
There was a problem hiding this comment.
Looks good from what I can tell 🧸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the creation of possible method argument options from the view to the languages. This allows differentiating between the languages, for example by using
Argument[self]for Ruby instead ofArgument[this]. Right now, this is the only difference, but in the future there will be more differences, likeArgument[block]for Ruby and keyword arguments for Ruby.Checklist
ready-for-doc-reviewlabel there.