Load existing data extension YAML in editor#2265
Conversation
This loads in the existing data extension YAML file for the selected database. It only supports the filename we save it to, and will not load it from any other data extension YAML files.
…-extension-editor-yaml-load
| void extLogger.log(`Saved data extension YAML to ${modelFilename}`); | ||
| } | ||
|
|
||
| protected async readExistingYaml(): Promise<void> { |
There was a problem hiding this comment.
Is readExistingModeledMethods() a better name for this? We refer to YAML in function and message names, but that feels like an implementation detail.
Also, usually with readXXX functions I expect something to be retuned. How about loadXXX instead?
There was a problem hiding this comment.
Sorry my comment was covering too many things - what do you think about updating messages as well to drop "yaml" and use "modeledMethods" e.g. setExistingYamlData -> setExistingModeledMethods?
There was a problem hiding this comment.
Good call! I've now moved all methods dealing with YAML from the webview to the extension. This also makes it easier to show an error message, so I've also added a simple error message when the data in the file is invalid.
…on-editor-yaml-load
This loads in the existing data extension YAML file for the selected database. It only supports the filename we save it to, and will not load it from any other data extension YAML files.
Based on #2264
Checklist
ready-for-doc-reviewlabel there.