Skip to content

Add saving of data extension editor table to YAML#2264

Merged
koesie10 merged 3 commits intomainfrom
koesie10/data-extension-editor-yaml
Apr 6, 2023
Merged

Add saving of data extension editor table to YAML#2264
koesie10 merged 3 commits intomainfrom
koesie10/data-extension-editor-yaml

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Apr 4, 2023

This adds the ability to save the modelled methods in the data extensions editor to a YAML file named after the database name. It will save it to the ql submodule for now. Support for data extension packs will be added later.

Based on #2263

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This adds the ability to save the modeled methods in the data extensions
editor to a YAML file named after the database name. It will save it to
the `ql` submodule for now. Support for data extension packs will be
added later.
@koesie10 koesie10 added the secexp label Apr 4, 2023
@koesie10 koesie10 requested review from a team as code owners April 4, 2023 11:34
Base automatically changed from koesie10/data-extensions-editor-calls to main April 5, 2023 14:55
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one code readability comment that I'd like to see addressed before merging.

Comment thread extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts Outdated
@koesie10 koesie10 enabled auto-merge April 6, 2023 08:13
@koesie10 koesie10 merged commit d60bcf3 into main Apr 6, 2023
@koesie10 koesie10 deleted the koesie10/data-extension-editor-yaml branch April 6, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants