[dead-code] chore: remove dead functions — 4 functions removed

[github-actions]

Dead Code Removal

This PR removes unreachable Go functions identified by the deadcode static analyzer.

Functions Removed

Function	File
fastParseTitle	pkg/cli/workflows.go
MergeModelAliases	pkg/workflow/model_aliases.go
extractOTLPConfigFromRaw	pkg/workflow/observability_otlp.go
IsBare	pkg/workflow/model_identifier.go

Tests Removed

Test	File	Reason
TestFastParseTitle	pkg/cli/commands_utils_test.go	Exclusively tested fastParseTitle
TestMergeModelAliases	pkg/workflow/model_aliases_test.go	Exclusively tested MergeModelAliases
TestExtractOTLPConfigFromRaw	pkg/workflow/observability_otlp_test.go	Exclusively tested extractOTLPConfigFromRaw
TestExtractOTLPConfigFromRaw_MapHeaders	pkg/workflow/observability_otlp_test.go	Exclusively tested extractOTLPConfigFromRaw

Callers in TestBuildAWFConfigJSON_ModelsSection were updated to use MergeImportedModelAliases(nil, ...) directly (the function MergeModelAliases was a thin wrapper around it).

Verification

• ✅ go build ./... — passes
• ✅ go vet ./... — passes
• ✅ go vet -tags=integration ./... — passes
• ✅ make fmt — no changes needed

Dead Function Count

• Before this batch: ~11 functions
• Removed in this PR: 4 functions
• Remaining: ~7 functions (includes false positives like validatePiEngineRequirements which is live)

---

Automated by Dead Code Removal workflow — https://github.com/github/gh-aw/actions/runs/25326109980

Generated by Dead Code Removal Agent · ● 4.8M · ◷

• expires on May 7, 2026, 3:24 PM UTC

[Copilot]

Pull request overview

Removes Go functions reported as unreachable by the deadcode analyzer, along with their now-obsolete unit tests, to reduce maintenance surface area.

Changes:

• Removed dead helpers in CLI/workflow packages (fastParseTitle, MergeModelAliases, extractOTLPConfigFromRaw, (*ParsedModelIdentifier).IsBare).
• Removed tests that exclusively covered the deleted functions.
• Updated remaining tests to call MergeImportedModelAliases(nil, ...) directly.

Show a summary per file

File	Description
pkg/workflow/observability_otlp.go	Removes the dead raw-frontmatter OTLP extraction helper.
pkg/workflow/observability_otlp_test.go	Removes tests that only exercised the deleted OTLP extraction helper.
pkg/workflow/model_identifier.go	Removes unused exported IsBare method on ParsedModelIdentifier.
pkg/workflow/model_aliases.go	Removes dead exported wrapper MergeModelAliases.
pkg/workflow/model_aliases_test.go	Removes wrapper-specific tests; updates callers to use MergeImportedModelAliases.
pkg/cli/workflows.go	Removes dead fastParseTitle helper (string-based parsing).
pkg/cli/commands_utils_test.go	Removes tests that only exercised the deleted fastParseTitle helper.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/cli/workflows.go:332

• The doc comment still references fastParseTitle, but that helper was removed in this PR. Please update the wording to avoid pointing to a non-existent function (e.g., compare against reading/parsing the whole file into memory).

// fastParseTitleFromReader scans lines from r for the first H1 header, skipping
// an optional frontmatter block, without reading the entire file into memory.
// This is more efficient than fastParseTitle for file-based callers because it
// stops reading as soon as the title is found.
//

• Files reviewed: 7/7 changed files
• Comments generated: 1

[github-actions]

🧪 Test Quality Sentinel Report

Test Quality Score: N/A

i️ No new tests to analyze — this PR only removes tests.

Metric	Value
New/modified tests analyzed	0
Test functions removed	3
Production functions removed	4

---

Summary

This PR removes dead code — 4 production functions and their corresponding test functions were deleted:

• TestFastParseTitle (pkg/cli/commands_utils_test.go) — removed along with fastParseTitle()
• TestMergeModelAliases (pkg/workflow/model_aliases_test.go) — removed along with MergeModelAliases()
• TestExtractOTLPConfigFromRaw (pkg/workflow/observability_otlp_test.go) — removed along with extractOTLPConfigFromRaw()
• TestExtractOTLPConfigFromRaw_MapHeaders (pkg/workflow/observability_otlp_test.go) — removed along with the dead helper

The 2 lines added in model_aliases_test.go are call-site updates (MergeModelAliases → MergeImportedModelAliases) in existing tests — not new test functions.

Verdict

✅ Check passed. No new tests were introduced. Removing tests for deleted dead code is correct hygiene — no behavioral coverage was lost.

References: §25332856533

🧪 Test quality analysis by Test Quality Sentinel · ● 505.7K · ◷

[github-actions]

✅ Test Quality Sentinel: N/A. No new tests introduced — this PR removes tests for deleted dead code. Correct hygiene, no behavioral coverage lost.