chore: remove dead functions — 4 functions removed (#30167)

Author: github-actions[bot]

pkg/cli/commands_utils_test.go

@@ -113,113 +113,6 @@ func TestExtractWorkflowNameFromFile_NonExistentFile(t *testing.T) {
 	}
 }
 
-func TestFastParseTitle(t *testing.T) {
-	tests := []struct {
-		name        string
-		content     string
-		expected    string
-		expectError bool
-	}{
-		{
-			name: "H1 after frontmatter",
-			content: `---
-title: Test
----
-
-# My Workflow Title
-
-Some content.`,
-			expected: "My Workflow Title",
-		},
-		{
-			name: "H1 with trailing spaces",
-			content: `---
-engine: copilot
----
-
-# Weekly Research   
-
-Content here.`,
-			expected: "Weekly Research",
-		},
-		{
-			name: "H1 without frontmatter",
-			content: `# Simple Title
-
-No frontmatter here.`,
-			expected: "Simple Title",
-		},
-		{
-			name:     "H1 is first line (no frontmatter)",
-			content:  `# Inline Title`,
-			expected: "Inline Title",
-		},
-		{
-			name:     "no H1 header",
-			content:  "Just some text without headers.",
-			expected: "",
-		},
-		{
-			name: "only H2 headers",
-			content: `---
-engine: copilot
----
-
-## Not an H1`,
-			expected: "",
-		},
-		{
-			name:     "empty content",
-			content:  "",
-			expected: "",
-		},
-		{
-			name: "unclosed frontmatter returns error",
-			content: `---
-title: Oops
-`,
-			expectError: true,
-		},
-		{
-			name: "dash in middle of content is not frontmatter",
-			content: `Some text
-
----
-
-# Not Skipped`,
-			expected: "Not Skipped",
-		},
-		{
-			name: "H1 inside frontmatter is ignored",
-			content: `---
-# not a header
----
-
-# Real Title`,
-			expected: "Real Title",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			got, err := fastParseTitle(tt.content)
-			if tt.expectError {
-				if err == nil {
-					t.Errorf("fastParseTitle(%q) expected error, got nil", tt.content)
-				}
-				return
-			}
-			if err != nil {
-				t.Errorf("fastParseTitle(%q) unexpected error: %v", tt.content, err)
-				return
-			}
-			if got != tt.expected {
-				t.Errorf("fastParseTitle(%q) = %q, want %q", tt.content, got, tt.expected)
-			}
-		})
-	}
-}
-
 func TestIsGitRepo(t *testing.T) {
 	// Test in current directory (should be a git repo based on project setup)
 	result := isGitRepo()

pkg/cli/workflows.go

@@ -325,43 +325,6 @@ func filterMarkdownFilesWithFrontmatter(mdFiles []string) ([]string, error) {
 	return workflowFiles, nil
 }
 
-// fastParseTitle scans markdown content for the first H1 header, skipping an
-// optional frontmatter block, without performing a full YAML parse.
-//
-// Frontmatter is recognised only when "---" appears on the very first line
-// (matching the behaviour of ExtractFrontmatterFromContent). Returns the H1
-// title text, or ("", nil) when no H1 header is present. Returns an error if
-// frontmatter is opened but never closed.
-func fastParseTitle(content string) (string, error) {
-	firstLine := true
-	inFrontmatter := false
-	for line := range strings.SplitSeq(content, "\n") {
-		trimmed := strings.TrimSpace(line)
-		if firstLine {
-			firstLine = false
-			if trimmed == "---" {
-				inFrontmatter = true
-				continue
-			}
-		} else if inFrontmatter {
-			if trimmed == "---" {
-				inFrontmatter = false
-			}
-			continue
-		}
-		if strings.HasPrefix(trimmed, "# ") {
-			return strings.TrimSpace(trimmed[2:]), nil
-		}
-	}
-
-	// Unclosed frontmatter is an error (consistent with ExtractFrontmatterFromContent).
-	if inFrontmatter {
-		return "", errors.New("frontmatter not properly closed")
-	}
-
-	return "", nil
-}
-
 // fastParseTitleFromReader scans lines from r for the first H1 header, skipping
 // an optional frontmatter block, without reading the entire file into memory.
 // This is more efficient than fastParseTitle for file-based callers because it

pkg/workflow/model_aliases.go

@@ -170,16 +170,3 @@ func MergeImportedModelAliases(importedModels []map[string][]string, frontmatter
 	modelAliasesLog.Printf("Final alias map has %d entries", len(merged))
 	return merged
 }
-
-// MergeModelAliases merges the frontmatter-defined model aliases on top of the
-// builtin aliases and returns the combined map.  Frontmatter entries always take
-// precedence: if the same key exists in both the builtins and the frontmatter
-// definition, the frontmatter value replaces the builtin value entirely.
-//
-// If frontmatterModels is nil or empty, the builtin aliases are returned as-is.
-//
-// For the full three-layer merge that also incorporates imported workflow aliases,
-// use MergeImportedModelAliases.
-func MergeModelAliases(frontmatterModels map[string][]string) map[string][]string {
-	return MergeImportedModelAliases(nil, frontmatterModels)
-}

pkg/workflow/model_aliases_test.go

@@ -53,56 +53,6 @@ func TestBuiltinModelAliases(t *testing.T) {
 	assert.NotEqual(t, aliases["sonnet"], aliases2["sonnet"], "BuiltinModelAliases should return a fresh copy each time")
 }
 
-// TestMergeModelAliases verifies that frontmatter-defined aliases are merged on top
-// of the builtins.
-func TestMergeModelAliases(t *testing.T) {
-	t.Run("nil frontmatter returns all builtins", func(t *testing.T) {
-		merged := MergeModelAliases(nil)
-		builtins := BuiltinModelAliases()
-		assert.Len(t, merged, len(builtins), "nil frontmatter should return exactly the builtins")
-		for k, v := range builtins {
-			assert.Equal(t, v, merged[k], "builtin alias %q should be present unchanged", k)
-		}
-	})
-
-	t.Run("empty frontmatter returns all builtins", func(t *testing.T) {
-		merged := MergeModelAliases(map[string][]string{})
-		builtins := BuiltinModelAliases()
-		assert.Len(t, merged, len(builtins), "empty frontmatter should return exactly the builtins")
-	})
-
-	t.Run("frontmatter override replaces builtin entry", func(t *testing.T) {
-		custom := map[string][]string{
-			"sonnet": {"myvendor/sonnet-custom"},
-		}
-		merged := MergeModelAliases(custom)
-		assert.Equal(t, []string{"myvendor/sonnet-custom"}, merged["sonnet"],
-			"frontmatter override should replace the builtin sonnet alias")
-		// Other builtins should be unaffected.
-		assert.NotEmpty(t, merged["haiku"], "haiku builtin should still be present")
-	})
-
-	t.Run("frontmatter adds new alias", func(t *testing.T) {
-		custom := map[string][]string{
-			"my-alias": {"copilot/my-model"},
-		}
-		merged := MergeModelAliases(custom)
-		assert.Equal(t, []string{"copilot/my-model"}, merged["my-alias"],
-			"new frontmatter alias should be present in merged map")
-		// Builtins should still be present.
-		assert.NotEmpty(t, merged["sonnet"], "sonnet builtin should still be present")
-	})
-
-	t.Run("default policy key is supported", func(t *testing.T) {
-		custom := map[string][]string{
-			"": {"sonnet", "gpt-5-codex"},
-		}
-		merged := MergeModelAliases(custom)
-		assert.Equal(t, []string{"sonnet", "gpt-5-codex"}, merged[""],
-			"default policy (empty key) should be stored and returned")
-	})
-}
-
 // TestBuildAWFConfigJSON_ModelsSection verifies model alias behaviour in BuildAWFConfigJSON.
 //
 // NOTE: The "models" field is intentionally excluded from the AWF config JSON until the
@@ -120,7 +70,7 @@ func TestBuildAWFConfigJSON_ModelsSection(t *testing.T) {
 				NetworkPermissions: &NetworkPermissions{
 					Firewall: &FirewallConfig{Enabled: true},
 				},
-				ModelMappings: MergeModelAliases(nil),
+				ModelMappings: MergeImportedModelAliases(nil, nil),
 			},
 		}
 
@@ -153,7 +103,7 @@ func TestBuildAWFConfigJSON_ModelsSection(t *testing.T) {
 				NetworkPermissions: &NetworkPermissions{
 					Firewall: &FirewallConfig{Enabled: true},
 				},
-				ModelMappings: MergeModelAliases(custom),
+				ModelMappings: MergeImportedModelAliases(nil, custom),
 			},
 		}
 

pkg/workflow/model_identifier.go

@@ -73,9 +73,6 @@ type ParsedModelIdentifier struct {
 	Params map[string]string
 }
 
-// IsBare reports whether the identifier is a bare name (no provider prefix).
-func (p *ParsedModelIdentifier) IsBare() bool { return p.Provider == "" }
-
 // Defined parameter keys recognised by the spec (Section 6).
 const (
 	modelParamEffort      = "effort"

pkg/workflow/observability_otlp.go

@@ -138,68 +138,6 @@ func generateOTLPHeadersMaskStep() string {
 	return sb.String()
 }
 
-// extractOTLPConfigFromRaw reads the first OTLP endpoint and its headers directly
-// from the raw frontmatter map[string]any.  The `endpoint` field may be:
-//
-//   - a string:  backward-compat URL + optional top-level `headers` field
-//   - an object: {url: "...", headers: {...}} — the object's own headers are used
-//   - an array:  [{url: ..., headers: ...}, ...] — only the first element is returned
-//
-// The third return value is true when the deprecated string form was used for headers,
-// so the caller can emit a deprecation warning.
-func extractOTLPConfigFromRaw(frontmatter map[string]any) (endpoint, headers string, deprecated bool) {
-	obs, ok := frontmatter["observability"]
-	if !ok {
-		return
-	}
-	obsMap, ok := obs.(map[string]any)
-	if !ok {
-		return
-	}
-	otlp, ok := obsMap["otlp"]
-	if !ok {
-		return
-	}
-	otlpMap, ok := otlp.(map[string]any)
-	if !ok {
-		return
-	}
-
-	endpointRaw := otlpMap["endpoint"]
-	switch ep := endpointRaw.(type) {
-	case string:
-		if ep == "" {
-			return
-		}
-		endpoint = ep
-		if raw, ok := otlpMap["headers"]; ok {
-			headers, deprecated = normalizeOTLPHeaders(raw)
-		}
-	case map[string]any:
-		// Object form: endpoint: {url: "...", headers: {...}}
-		if url, _ := ep["url"].(string); url != "" {
-			endpoint = url
-			if h, ok := ep["headers"]; ok {
-				headers, deprecated = normalizeOTLPHeaders(h)
-			}
-		}
-	case []any:
-		// Array form: return only the first element (callers needing all entries
-		// should use collectAllOTLPEndpoints instead).
-		if len(ep) > 0 {
-			if firstItem, ok := ep[0].(map[string]any); ok {
-				if url, _ := firstItem["url"].(string); url != "" {
-					endpoint = url
-					if h, ok := firstItem["headers"]; ok {
-						headers, deprecated = normalizeOTLPHeaders(h)
-					}
-				}
-			}
-		}
-	}
-	return
-}
-
 // otlpEndpointEntry is the wire format used when encoding the GH_AW_OTLP_ENDPOINTS
 // environment variable as a JSON array.  Each entry carries the endpoint URL and
 // its optional normalized (comma-separated key=value) headers string.