C#: Correctly parse operator names in MaD#14678
Merged
hvitved merged 4 commits intogithub:mainfrom Nov 7, 2023
Merged
Conversation
0ddfa1d to
4a4b924
Compare
4a4b924 to
3e3ea51
Compare
michaelnebel
reviewed
Nov 6, 2023
| /** | ||
| * Holds if a source model exists for the given parameters. | ||
| */ | ||
| extensible predicate sourceModel( |
Contributor
There was a problem hiding this comment.
Could we keep this in the ExternalFlowExtensions file instead - to make sure this is streamlined with other languages (for java - the model related predicates in ExternalFlow are not just aliases)?
Contributor
Author
There was a problem hiding this comment.
That means those predicates are exposed; do we really want/need that?
Contributor
There was a problem hiding this comment.
Maybe then move the entire ExternalFlowExtensions file as well (also for Java)?
michaelnebel
reviewed
Nov 6, 2023
| private predicate callableSpecInfo(Callable c, string namespace, string type, string name) { | ||
| c.getDeclaringType().hasQualifiedName(namespace, type) and | ||
| c.getName() = name | ||
| hasName(c, name) |
Contributor
There was a problem hiding this comment.
🙀 So was it the case, that even though the models existed they were not applied correctly to the operator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were incorrectly using the operator name (e.g.
+) instead of the operator function name (e.g.op_Addition).