Skip to content

Swift: Add AdditionalTaintStep #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 1 commit into from
Nov 15, 2022
Merged

Swift: Add AdditionalTaintStep #11273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions swift/ql/lib/codeql/swift/dataflow/FlowSteps.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
import swift
private import codeql.swift.dataflow.DataFlow

/**
* A unit class for adding additional taint steps.
*
* Extend this class to add additional taint steps that should apply to all
* taint configurations.
*/
class AdditionalTaintStep extends Unit {
/**
* Holds if the step from `node1` to `node2` should be considered a taint
* step for all configurations.
*/
abstract predicate step(DataFlow::Node node1, DataFlow::Node node2);
}
Comment on lines +10 to +16
Copy link
Copy Markdown
Contributor

@MathiasVP MathiasVP Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍.


/**
* A `Content` that should be implicitly regarded as tainted whenever an object with such `Content`
* is itself tainted.
Expand Down
2 changes: 2 additions & 0 deletions swift/ql/lib/codeql/swift/dataflow/internal/TaintTrackingPrivate.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ private module Cached {
or
// flow through a flow summary (extension of `SummaryModelCsv`)
FlowSummaryImpl::Private::Steps::summaryLocalStep(nodeFrom, nodeTo, false)
or
any(AdditionalTaintStep a).step(nodeFrom, nodeTo)
}

/**
Expand Down