Swift: Add AdditionalTaintStep#11273
Merged
atorralba merged 1 commit intogithub:mainfrom Nov 15, 2022
Merged
Conversation
MathiasVP
reviewed
Nov 15, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
The code LGTM, but we should make sure to sync this up with what @karimhamdanali has been working on.
Comment on lines
+10
to
+16
| class AdditionalTaintStep extends Unit { | ||
| /** | ||
| * Holds if the step from `node1` to `node2` should be considered a taint | ||
| * step for all configurations. | ||
| */ | ||
| abstract predicate step(DataFlow::Node node1, DataFlow::Node node2); | ||
| } |
| } | ||
|
|
||
| /** A global taint step for the read of the `utf8` field of a tainted `String`. */ | ||
| private class StringUtf8Step extends AdditionalTaintStep { |
Contributor
Author
There was a problem hiding this comment.
Hm, true. It's even more general than my approach, so we should prioritize that. I'm surprised that #11185 doesn't affect the data.swift test cases though 🤔
Contributor
Author
There was a problem hiding this comment.
Ok, I now see that the base of that PR didn't yet include the init CSV model of Data, that's why other test cases aren't affected. I'm going to remove the string step then, and make this PR only add the abstract AdditionalTaintStep.
b1c894e to
8ca004f
Compare
String.utf8 viewAdditionalTaintStep
MathiasVP
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the abstract class
AdditionalTaintStepto allow creating flow steps that apply to all taint tracking configurations.