Ruby: Block for steps into self parameters in trackModuleAccess#10895
Merged
hvitved merged 2 commits intogithub:mainfrom Oct 20, 2022
Merged
Ruby: Block for steps into self parameters in trackModuleAccess#10895hvitved merged 2 commits intogithub:mainfrom
self parameters in trackModuleAccess#10895hvitved merged 2 commits intogithub:mainfrom
Conversation
7cc806c to
d69c622
Compare
d69c622 to
faaead6
Compare
asgerf
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #10705, we apply an open-world assumption when resolving calls to singleton method, just like with calls to instance methods, so we should no longer track module accesses into
selfparameters. This removes false positive call graph edges likeMoreover, we were also not properly handling calls to
self.newinside singleton methods defined via singleton classes.