Ruby: Take overrides into account for singleton methods defined on modules#10705
Merged
hvitved merged 3 commits intogithub:mainfrom Oct 7, 2022
Merged
Ruby: Take overrides into account for singleton methods defined on modules#10705hvitved merged 3 commits intogithub:mainfrom
hvitved merged 3 commits intogithub:mainfrom
Conversation
0cd40eb to
b3b9550
Compare
b3b9550 to
48bdf13
Compare
asgerf
reviewed
Oct 7, 2022
Contributor
asgerf
left a comment
There was a problem hiding this comment.
LGTM with a minor comment
Related to our previous discussion, I noticed some of the new call edges are calls to user-defined new methods.
| } | ||
|
|
||
| pragma[nomagic] | ||
| private MethodBase lookupSingletonMethod(Module m, string name) { |
Contributor
There was a problem hiding this comment.
Could you add some QLDoc indicating that this takes inheritance into account, and likewise on singletonMethodOnModule.
I'd probably have named these predicates in a way that clarifies their relationship, such as:
lookupOwnSingletonMethodlookupSingletonMethod
Contributor
Author
There was a problem hiding this comment.
I simply used the naming after the existing lookupMethod predicate for instance methods. I'll add ql doc.
asgerf
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously not handling cases like this:
DCA shows 20k new call edges, and those I sampled looked legit.