make manager calls nmake /F Makefile.win on Windows#2426
make manager calls nmake /F Makefile.win on Windows#2426josevalim merged 1 commit intoelixir-lang:masterfrom
Conversation
There was a problem hiding this comment.
Quick question: does make ever work on Windows? I am asking because maybe we should check if nmake is available first? Or at least check if Makefile.win is available? Isn't there a chance a makefile will work fine on both OS?
There was a problem hiding this comment.
@josevalim make does work on Windows (that's how I build Elixir) but Makefiles written for make typically expect gcc to be installed, which on Windows isn't guaranteed and could create compatibility issues if used. The motivation behind avoiding make is that if people use a precompiled Elixir package don't need to use MinGW.
There was a problem hiding this comment.
Also, I'm still looking into how to implement C interop stuff in MIx directly, so we can avoid makefiles altogether.
There was a problem hiding this comment.
Ok so I think we should definitely check if there is a Makefile.win before invoking nmake \F Makefile.win for now. I will amend it locally.
make manager calls nmake /F Makefile.win on Windows
Dependencies on Windows should compile with
nmake /F Makefile.win. So these commits set:makeas the manager if eitherMakefileORMakefile.winexist, then makes the platform-appropriate call.