Build on Windows using MSVC, nmake#7
Merged
josevalim merged 2 commits intodevinus:masterfrom Jun 18, 2014
chyndman:win-nmake
Merged
Build on Windows using MSVC, nmake#7josevalim merged 2 commits intodevinus:masterfrom chyndman:win-nmake
josevalim merged 2 commits intodevinus:masterfrom
chyndman:win-nmake
Conversation
Contributor
|
Thank you! Quick question: what does the |
Owner
|
Probably injects ENV vars into your session. |
Owner
|
MSVC comes with a MSVC version of the console as a shortcut which I assume does this by default when run, but not everybody wants to run cmd.exe when on Windows. |
Contributor
Author
|
@devinus Correct, it sets up environment variables. Calling it manually makes sure the architecture matches Erlang (the shortcut uses |
josevalim
pushed a commit
that referenced
this pull request
Jun 18, 2014
Build on Windows using MSVC, nmake
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits allow for building on Windows. I based this on my ExDoc work and submitted a PR here per @josevalim's request. The same steps to build hold:
"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" _ARCH_, where_ARCH_is eitherx86(if you installed 32-bit Erlang) oramd64(64-bit Erlang).mix compile.Requires elixir-lang/elixir #2426.