Migrate Enumerable to use an iteratees based solution#1922
Merged
Migrate Enumerable to use an iteratees based solution#1922
Conversation
added 16 commits
December 11, 2013 15:01
Details are described in the Enumerable docs. This new implementation allows us to implement interleaving functions (like zip) while avoiding a huge penalty in regular enumeration.
…uples The motivation behind this change is to not force every application to implement count/1 and member?/2 manually. It also allows us in the future to add functions like Enum.counted?/1 that will return true if count is pre-calculated.
Contributor
|
Cool stuff 👍 |
Contributor
|
Awesome work, josevalim. This will open a lot of doors. |
josevalim
pushed a commit
that referenced
this pull request
Dec 12, 2013
Migrate Enumerable to use an iteratees based solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the Enumerable protocol to use a solution based on iteratees. This allow us to halt enumeration (cleaning up the implementation of functions like
take/2anddrop/2) and also adds the possibility of interleaving enumerables via suspend. To show case the new functionalities we got, this pull request considerably extends theStreamAPI, by adding functions likezip/2,chunks/4and more. More info can be found in the updated documentation for Enumerable. @pminten is also working on a blog post that explains the underlying mechanisms quite well.On the negative side, this pull request does backwards incompatible changes on how the Enumerable protocol works. For this reason, the next Elixir release will be tagged 0.12.0 (to be released this weekend).
Huge thanks to @jessitron for pairing with me on the initial implementation of iteratees. Feedback is welcome!
/cc @ericmj @pminten @devinus @meh