Skip to content

Blog post about the new enumerators#179

Merged
josevalim merged 1 commit intoelixir-lang:masterfrom
pminten:cont-enumerators-post
Dec 12, 2013
Merged

Blog post about the new enumerators#179
josevalim merged 1 commit intoelixir-lang:masterfrom
pminten:cont-enumerators-post

Conversation

@pminten
Copy link
Copy Markdown

@pminten pminten commented Dec 11, 2013

I guess it's a bit early considering enumerators aren't in master yet and so the date will probably need to be adjusted before this goes in, but I'd like to get a few more eyeballs on this post.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You name it coll here, calls it enumerable later. Maybe pick one of them? Maybe enum?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Fixed.

@josevalim
Copy link
Copy Markdown
Member

Done reviewing, thanks @pminten ! One final thing, can you add the arity to the function references? Like Enum.reduce/3?

@pminten
Copy link
Copy Markdown
Author

pminten commented Dec 11, 2013

@josevalim Updated, thanks for the review.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to "Internals" or "What's new in elixir" categories? I want to avoid creating multiple and multiple categories.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I wasn't quite happy with that new category either but didn't really know where to put it.

@josevalim
Copy link
Copy Markdown
Member

I added one last note that I missed the first time. Thanks a lot @pminten! When do you think we should publish it? As soon as we merge it? Maybe we should link to the pull request? elixir-lang/elixir#1922

@pminten
Copy link
Copy Markdown
Author

pminten commented Dec 11, 2013

I've rewritten the first paragraph to assume that the code is in master but 0.12.0 is not yet out. I imagine this post can be useful before the release as it helps people understand what's going on so that, hopefully, more people will experiment with this and notice any bugs before the release. I've also added a link to the PR.

josevalim pushed a commit that referenced this pull request Dec 12, 2013
Blog post about the new enumerators
@josevalim josevalim merged commit 0cef704 into elixir-lang:master Dec 12, 2013
@pminten pminten deleted the cont-enumerators-post branch December 12, 2013 10:44
josevalim pushed a commit that referenced this pull request Jun 17, 2014
Blog post about the new enumerators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants