fix: Dispose of PooledBitStream used in the MessageBatcher, also stor…#436
Merged
fix: Dispose of PooledBitStream used in the MessageBatcher, also stor…#436
Conversation
0xFA11
reviewed
Jan 11, 2021
0xFA11
reviewed
Jan 11, 2021
NoelStephensUnity
approved these changes
Jan 11, 2021
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Looks good! All minor tweaks made and the other called out items can wait until we migrate Batching to the job system and/or when we update the stream stuff (i.e. BatchThreshold can be exposed later and the suggestion to invoke the dispose method via a using statement will go away when stream read/write stuff is replaced).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es only the FrameQueueItem's channel, as opposed to the whole FrameQueueItem
MTT-193 MTT-250