Skip to content

fix: resetting the NetworkVariable dirty status at end of frame, …#2328

Closed
jeffreyrainy wants to merge 11 commits intodevelopfrom
fix/mtt-5121-networklist-hide-remove
Closed

fix: resetting the NetworkVariable dirty status at end of frame, …#2328
jeffreyrainy wants to merge 11 commits intodevelopfrom
fix/mtt-5121-networklist-hide-remove

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

@jeffreyrainy jeffreyrainy commented Dec 1, 2022

… even if a given NetworkVariable is not sent to any client

Also queueing NetworkShow to be done at end-of-frame, to address modified-after-shown objects.

Also changing NetworkHide so that hiding objects that would be shown at end of frame does nothing, but emit a warning.

MTT-5121
#2306

Changelog:

- `NetworkShow()` of `NetworkObject`s are delayed until the end of the frame to ensure consistency of delta-driven variables like `NetworkList`.
- Dirty `NetworkObject` are reset at end-of-frame and not at serialization time.
- `NetworkHide()` of an object that was just `NetworkShow()`n produces a warning, as remote clients will _not_ get a spawn/despawn pair.

… if a given NetworkVariable is not sent to any client
@jeffreyrainy
Copy link
Copy Markdown
Contributor Author

Discarding this one, as it got superseded by #2344

@jeffreyrainy jeffreyrainy deleted the fix/mtt-5121-networklist-hide-remove branch December 12, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant