fix: NetworkAnimator destinationStateMachine exception [MTT-5083] by NoelStephensUnity · Pull Request #2309 · Unity-Technologies/com.unity.netcode.gameobjects

NoelStephensUnity · 2022-11-14T20:14:58Z

This resolves the issue where NetworkAnimator was not checking for AnimatorStateTtansition.destinationStateMachine, which was causing an exception, and adding any possible states with triggers defined within it. This also prevents the server from sending itself messages about animation state changing (#2305).

MTT-5083
MTT-5122

GitHub Issues Resolved:
#2305
#2293
#2374
#2366
#2368

Changelog

Fixed: NetworkAnimator issue where it was not checking for AnimatorStateTtansition.destinationStateMachine and any possible sub-states defined within it.
Fixed: NetworkAnimator issue where the host client was receiving the ClientRpc animation updates when the host was the owner.
Fixed: NetworkAnimator issue with using pooled objects and when specific properties are cleaned during despawn and destroy.
Fixed: issue where NetworkAnimator was checking for animation changes when the associated NetworkObject was not spawned.

Testing and Documentation

Includes integration test updates.
Includes manual test updates.

This fixes the issue where NetworkAnimator was not taking into consideration `AnimatorStateTtansition.destinationStateMachine`. Now, NetworkAnimator parses each destinationStateMachine's states for trigger transitions and includes those in the transition table.

passing setTrigger bool to internal method.

Manual test that validates this fix.

Only send animation updates to clients and not host client when animation state changes.

MTT-5083 Updating test to validate states defined within a destinationStateMachine are triggering.

MTT-5083 Adding entry for this fix.

MTT-5083 Adding the PR number to the changelog entry.

…ne-exception

jeffreyrainy

.

jeffreyrainy

.

jeffreyrainy

Mistakenly approved wrong PR, please wait for actual review before acting on this approval.

approval was by mistake 🤷

…ne-exception

This includes some updates to NetworkAnimator that will remove the need to synchronize client's using RPCs but instead use the new OnSynchronize method. Fixed an issue with using pooled objects and when specific properties are cleaned during despawn and destroy.

Made components visible to testproject again although I might try to figure out a better way to handle these two ways of testing. Updated the NetworkAnimatorTests to acquire the state info from NetworkAnimator.SynchronizationStateInfo.

Making the NGO Components AssemblyInfo adjustment only expose internals if NGO_COMPONENTS_ASSEMBLY_RUNTIME_VISIBILITY is defined.

Removed enabling verbose debug in LateJoinSynchronizationTest

Adjusting to original serialized format for backwards compatibility.

…ne-exception

removed the AnimationSynchronizationData class as it really was not needed.

…ne-exception

This fixes the issue where NetworkAnimator will not check for animation changes unless the associated NetworkObject is spawned.

…ne-exception

dismiss

…ne-exception

Removing the NGO_COMPONENTS_ASSEMBLY_RUNTIME_VISIBILITY from the scriptingDefineSymbols. Replacing it with UNITY_INCLUDE_TESTS in the components AssemblyInfo.cs file. Adding an additional remark about the context of when CheckForAnimatorChanges is invoked.

Migrating all test related assemblies within the UNITY_INCLUDE_TESTS define region.

Minor fix for weapon attack option in manual test.

…ne-exception

updating what was fixed in this PR

NoelStephensUnity added 7 commits November 11, 2022 18:34

fix

5500c6b

This fixes the issue where NetworkAnimator was not taking into consideration `AnimatorStateTtansition.destinationStateMachine`. Now, NetworkAnimator parses each destinationStateMachine's states for trigger transitions and includes those in the transition table.

fix

353893b

passing setTrigger bool to internal method.

test manual

c9ff07c

Manual test that validates this fix.

fix

870be01

Only send animation updates to clients and not host client when animation state changes.

test

fb975dc

MTT-5083 Updating test to validate states defined within a destinationStateMachine are triggering.

update

2a49e2b

MTT-5083 Adding entry for this fix.

update

b379dd2

MTT-5083 Adding the PR number to the changelog entry.

NoelStephensUnity marked this pull request as ready for review November 14, 2022 20:45

NoelStephensUnity requested a review from a team as a code owner November 14, 2022 20:45

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

6ecf4d0

…ne-exception

jeffreyrainy previously approved these changes Nov 15, 2022

View reviewed changes

jeffreyrainy reviewed Nov 16, 2022

View reviewed changes

NoelStephensUnity added 3 commits November 18, 2022 11:33

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

7eb8316

…ne-exception

update and fix

4b6ed27

This includes some updates to NetworkAnimator that will remove the need to synchronize client's using RPCs but instead use the new OnSynchronize method. Fixed an issue with using pooled objects and when specific properties are cleaned during despawn and destroy.

test

8810b31

Made components visible to testproject again although I might try to figure out a better way to handle these two ways of testing. Updated the NetworkAnimatorTests to acquire the state info from NetworkAnimator.SynchronizationStateInfo.

NoelStephensUnity requested a review from 0xFA11 as a code owner November 19, 2022 00:20

NoelStephensUnity and others added 9 commits November 20, 2022 13:40

fix

07f8942

Making the NGO Components AssemblyInfo adjustment only expose internals if NGO_COMPONENTS_ASSEMBLY_RUNTIME_VISIBILITY is defined.

test

4e36786

Removed enabling verbose debug in LateJoinSynchronizationTest

fix

4314dd6

Adjusting to original serialized format for backwards compatibility.

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

7f5d45b

…ne-exception

update

19bf656

removed the AnimationSynchronizationData class as it really was not needed.

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

ddd03f0

…ne-exception

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

442ea04

…ne-exception

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

6bafef4

…ne-exception

fix

5ce321c

This fixes the issue where NetworkAnimator will not check for animation changes unless the associated NetworkObject is spawned.

jeffreyrainy approved these changes Dec 12, 2022

View reviewed changes

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

6a976d5

…ne-exception

NoelStephensUnity enabled auto-merge (squash) December 12, 2022 17:14

lpmaurice previously approved these changes Dec 14, 2022

View reviewed changes

NoelStephensUnity and others added 3 commits December 21, 2022 10:23

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

06472f8

…ne-exception

Merge develop into fix/networkanimator-destinationstatemachine-exception

d71655a

Merge develop into fix/networkanimator-destinationstatemachine-exception

2e9f8d9

NoelStephensUnity mentioned this pull request Jan 10, 2023

[Netcode] Detected the Host is sending itself animation updates! Please report this issue. #2374

Closed

update

3d764ec

Removing the NGO_COMPONENTS_ASSEMBLY_RUNTIME_VISIBILITY from the scriptingDefineSymbols. Replacing it with UNITY_INCLUDE_TESTS in the components AssemblyInfo.cs file. Adding an additional remark about the context of when CheckForAnimatorChanges is invoked.

NoelStephensUnity disabled auto-merge January 10, 2023 16:47

NoelStephensUnity and others added 3 commits January 10, 2023 11:01

update

46bf588

Migrating all test related assemblies within the UNITY_INCLUDE_TESTS define region.

update

ba515d8

Minor fix for weapon attack option in manual test.

Merge branch 'develop' into fix/networkanimator-destinationstatemachi…

cd110e6

…ne-exception

0xFA11 approved these changes Jan 12, 2023

View reviewed changes

update

bd5b81c

updating what was fixed in this PR

NoelStephensUnity enabled auto-merge (squash) January 12, 2023 18:15

NoelStephensUnity merged commit 4cd5092 into develop Jan 12, 2023

NoelStephensUnity deleted the fix/networkanimator-destinationstatemachine-exception branch January 12, 2023 20:45

This was referenced Jan 12, 2023

NetworkAnimator bug in Netcode 1.1 #2293

Closed

Warning: Detected the Host is sending itself animation updates! Please report this issue. #2366

Closed

[Netcode] Detected the Host is sending itself animation updates! Please report this issue. #2368

Closed

NoelStephensUnity mentioned this pull request Apr 6, 2023

[Netcode] Detected the Host is sending itself animation updates! Please report this issue. #2305

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: NetworkAnimator destinationStateMachine exception [MTT-5083]#2309

fix: NetworkAnimator destinationStateMachine exception [MTT-5083]#2309
NoelStephensUnity merged 29 commits intodevelopfrom
fix/networkanimator-destinationstatemachine-exception

NoelStephensUnity commented Nov 14, 2022 •

edited

Loading

Uh oh!

jeffreyrainy left a comment •

edited

Loading

Uh oh!

jeffreyrainy left a comment

Uh oh!

jeffreyrainy left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

NoelStephensUnity commented Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Testing and Documentation

Uh oh!

jeffreyrainy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffreyrainy left a comment

Choose a reason for hiding this comment

Uh oh!

jeffreyrainy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NoelStephensUnity commented Nov 14, 2022 •

edited

Loading

jeffreyrainy left a comment •

edited

Loading