refactor: Migrate menu settings to project settings [MTT-5001]#2285
Merged
NoelStephensUnity merged 10 commits intodevelopfrom Nov 2, 2022
Merged
Conversation
jeffreyrainy
approved these changes
Oct 31, 2022
0xFA11
reviewed
Oct 31, 2022
Contributor
0xFA11
left a comment
There was a problem hiding this comment.
Design-wise, it's a good direction I think but as it stands today, I wonder if it'd worth fragmenting "network settings" UX into 2 parts just for these options instead of keeping them under the still required NetworkManager inspector interface only.
Member
Author
Hmmm... interesting. I am all for migrating common settings outside of the NetworkManager UX. |
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…-Technologies#2285) * update Migrated the multiplayer tools install reminder over to the new Netcode for GameObjects settings. Deleted the UITestHelpers class completely as it is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves the two netcode menu settings over to Netcode for GameObjects in project settings.
MTT-5001
Changelog
NetworkObjectauto-add helper and Multiplayer Tools install reminder settings to Project Settings.NetworkObjectauto-add and Multiplayer Tools install reminder settings from the Menu interface.Testing and Documentation