Skip to content

fix: Removing objects that got deleted from list of Dirty NetworkObjects #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffreyrainy merged 2 commits into from
Sep 9, 2022
Merged

fix: Removing objects that got deleted from list of Dirty NetworkObjects #2185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c71042
fix: Removing objects that got deleted from list of Dirty NetworkObjects
jeffreyrainy Sep 8, 2022
4f77d5a
Merge branch 'develop' into fix/dirty-null-objects-MTT-4459
jeffreyrainy Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
#endif
try
{
// NetworkObject references can become null, when hidden or despawned. Once NUll, there is no point
// trying to process them, even if they were previously marked as dirty.
m_DirtyNetworkObjects.RemoveWhere((sobj) => sobj == null);

if (networkManager.IsServer)
{
foreach (var dirtyObj in m_DirtyNetworkObjects)
Expand Down