fix: Removing objects that got deleted from list of Dirty NetworkObjects#2185
Merged
jeffreyrainy merged 2 commits intodevelopfrom Sep 9, 2022
Merged
fix: Removing objects that got deleted from list of Dirty NetworkObjects#2185jeffreyrainy merged 2 commits intodevelopfrom
jeffreyrainy merged 2 commits intodevelopfrom
Conversation
LambdaCmplx
pushed a commit
to LambdaCmplx/com.unity.netcode.gameobjects
that referenced
this pull request
Sep 16, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issues such as #2136 where objects added to the list of dirty NetworkObject get deleted before we process the list.
The issue refuses to show in our test setup, so there sadly isn't any test for it. However, the code is simple enough and there would clearly be a null reference exception without it.
https://jira.unity3d.com/browse/MTT-4459