Skip to content

fix: splitting the internal and visible parts of OnNetworkSpawn#2143

Merged
NoelStephensUnity merged 7 commits intodevelopfrom
fix/MTT-4464
Aug 24, 2022
Merged

fix: splitting the internal and visible parts of OnNetworkSpawn#2143
NoelStephensUnity merged 7 commits intodevelopfrom
fix/MTT-4464

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

@jeffreyrainy jeffreyrainy marked this pull request as ready for review August 23, 2022 23:11
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner August 23, 2022 23:11
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) August 24, 2022 17:27
@NoelStephensUnity NoelStephensUnity merged commit 8a5fd45 into develop Aug 24, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/MTT-4464 branch August 24, 2022 18:18
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…y-Technologies#2143)

* fix: splitting the internal and visible parts of OnNetworkSpawn

* fix: Not throwing an exception when NetworkVariable is written to before being spawned. Logging a warning instead

Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants