chore: Fix build test#2139
Merged
ashwinimurt merged 1 commit intodevelopfrom Aug 22, 2022
Merged
Conversation
39a8d21 to
28c4eae
Compare
0xFA11
approved these changes
Aug 22, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build test used to throw an error
LogAssert.Expect(LogType.Error, "Error building player because build target was unsupported");when platform supports are not installed. This error is expected and correct, but it causes UTR to mark the entire suite as Failed on 2021.3 and 2020.3.So, change the test slightly to build only if
buildTargetSupportedhttps://jira.unity3d.com/browse/MTT-4059
Changelog
Testing and Documentation