Skip to content

fix: not sending all NetworkVariables #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 9 commits into from
Aug 24, 2022
Merged

fix: not sending all NetworkVariables #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6bb8748
fix: not sending all NetworkVariables to all clients when a client co…
jeffreyrainy Aug 21, 2022
5000cdc
fix
NoelStephensUnity Aug 22, 2022
ea42c3c
update
NoelStephensUnity Aug 23, 2022
acac32d
update
NoelStephensUnity Aug 23, 2022
fe46e57
test update
NoelStephensUnity Aug 23, 2022
665d255
Merge branch 'develop' into fix/netvar-optimization-mtt-4084-gh-1987
jeffreyrainy Aug 23, 2022
55b8b69
test update
NoelStephensUnity Aug 23, 2022
eb06396
Merge branch 'fix/netvar-optimization-mtt-4084-gh-1987' of https://gi…
NoelStephensUnity Aug 23, 2022
508be55
Merge branch 'develop' into fix/netvar-optimization-mtt-4084-gh-1987
NoelStephensUnity Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Additional documentation and release notes are available at [Multiplayer Documen

### Fixed

- Fixed not sending all NetworkVariables to all clients when a client connects to a server. (#1987)
- Fixed an issue where reading/writing more than 8 bits at a time with BitReader/BitWriter would write/read from the wrong place, returning and incorrect result. (#2130)
- Fixed issue with the internal `NetworkTransformState.m_Bitset` flag not getting cleared upon the next tick advancement. (#2110)
- Fixed interpolation issue with `NetworkTransform.Teleport`. (#2110)
Expand Down
2 changes: 0 additions & 2 deletions com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,6 @@ internal void SendSpawnCallForObject(ulong clientId, NetworkObject networkObject
};
var size = NetworkManager.SendMessage(ref message, NetworkDelivery.ReliableFragmentedSequenced, clientId);
NetworkManager.NetworkMetrics.TrackObjectSpawnSent(clientId, networkObject, size);

networkObject.MarkVariablesDirty(true);
}

internal ulong? GetSpawnParentId(NetworkObject networkObject)
Expand Down
Loading