fix: not sending all NetworkVariables#2135
Merged
NoelStephensUnity merged 9 commits intodevelopfrom Aug 24, 2022
Merged
Conversation
…nnects to a server. (#1987)
This resolves the remaining issues with the deferred message tests for this PR.
I believe this will fix the tests having instability issues as well.
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* fix: not sending all NetworkVariables to all clients when a client connects to a server. (Unity-Technologies#1987) * fix This fixes the issue with some of the tests failing. Disabled the tests where clients don't have a prefab defined. * update Fixing issues with the last 5 tests. * update Got another (of the five) test working. Adding some helpers to assure the prefabs are spawned before trying to check them. Updated some comments. * test update This resolves the remaining issues with the deferred message tests for this PR. * test update I believe this will fix the tests having instability issues as well. Co-authored-by: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: not sending all NetworkVariables to all clients when a client connects to a server. (#1987)
mtt-4084
Changelog
Testing and Documentation