fix: Fixed Owner-written NetworkVariable infinitely write themselves

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -25,6 +25,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Fixed NetworkLists not populating on client. NetworkList now uses the most recent list as opposed to the list at the end of previous frame, when sending full updates to dynamically spawned NetworkObject. The difference in behaviour is required as scene management spawns those objects at a different time in the frame, relative to updates. (#2062)
 - Fixed NetworkList Value event on the server. PreviousValue is now set correctly when a new value is set through property setter. (#2067)
 - Fixed NetworkList issue that showed when inserting at the very end of a NetworkList (#2099)
+- Fixed Owner-written NetworkVariable infinitely write themselves (#2109)
 
 ## [1.0.0] - 2022-06-27
 

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -587,14 +587,18 @@ internal void PostNetworkVariableWrite()
             MarkVariablesDirty(false);
         }
 
-        internal void VariableUpdate(ulong targetClientId)
+        internal void PreVariableUpdate()
         {
             if (!m_VarInit)
             {
                 InitializeVariables();
             }
 
             PreNetworkVariableWrite();
+        }
+
+        internal void VariableUpdate(ulong targetClientId)
+        {
             NetworkVariableUpdate(targetClientId, NetworkBehaviourId);
         }
 

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs

@@ -30,6 +30,11 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
                 {
                     foreach (var dirtyObj in m_DirtyNetworkObjects)
                     {
+                        for (int k = 0; k < dirtyObj.ChildNetworkBehaviours.Count; k++)
+                        {
+                            dirtyObj.ChildNetworkBehaviours[k].PreVariableUpdate();
+                        }
+
                         for (int i = 0; i < networkManager.ConnectedClientsList.Count; i++)
                         {
                             var client = networkManager.ConnectedClientsList[i];
@@ -56,6 +61,10 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
                     {
                         if (sobj.IsOwner)
                         {
+                            for (int k = 0; k < sobj.ChildNetworkBehaviours.Count; k++)
+                            {
+                                sobj.ChildNetworkBehaviours[k].PreVariableUpdate();
+                            }
                             for (int k = 0; k < sobj.ChildNetworkBehaviours.Count; k++)
                             {
                                 sobj.ChildNetworkBehaviours[k].VariableUpdate(NetworkManager.ServerClientId);