fix: Fixed Owner-written NetworkVariable infinitely write themselves #2128
Merged
jeffreyrainy merged 5 commits intodevelopfrom Aug 17, 2022
Merged
fix: Fixed Owner-written NetworkVariable infinitely write themselves #2128jeffreyrainy merged 5 commits intodevelopfrom
jeffreyrainy merged 5 commits intodevelopfrom
Conversation
…2109) Fixed by doing the pre-write as a separate step
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Any way to make a test for this update?
ShadauxCat
approved these changes
Aug 17, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…nity-Technologies#2128) * fix: Fixed Owner-written NetworkVariable infinitely write themselves (Unity-Technologies#2109) Fixed by doing the pre-write as a separate step * nit PR review :-) * Adding test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed by doing the pre-write as a separate step
#2109
MTT-4386
Changelog