Skip to content

fix: NetcodeIntegrationTest remove extra OnNewClientCreated call #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xFA11 merged 2 commits into from
Jun 8, 2022
Merged

fix: NetcodeIntegrationTest remove extra OnNewClientCreated call #2005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e6bf6
fix
NoelStephensUnity Jun 8, 2022
c9b89c5
style
NoelStephensUnity Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,9 @@ protected IEnumerator CreateAndStartNewClient()
{
var networkManager = NetcodeIntegrationTestHelpers.CreateNewClient(m_ClientNetworkManagers.Length);
networkManager.NetworkConfig.PlayerPrefab = m_PlayerPrefab;

// Notification that the new client (NetworkManager) has been created
// in the event any modifications need to be made before starting the client
OnNewClientCreated(networkManager);

NetcodeIntegrationTestHelpers.StartOneClient(networkManager);
Expand All @@ -302,7 +305,6 @@ protected IEnumerator CreateAndStartNewClient()
AssertOnTimeout($"{nameof(CreateAndStartNewClient)} timed out waiting for the new client to be connected!");
ClientNetworkManagerPostStart(networkManager);
VerboseDebug($"[{networkManager.name}] Created and connected!");
OnNewClientCreated(networkManager);
}

protected IEnumerator StopOneClient(NetworkManager networkManager, bool destroy = false)
Expand Down