Skip to content

fix: NetcodeIntegrationTest remove extra OnNewClientCreated call#2005

Merged
0xFA11 merged 2 commits intodevelopfrom
fix/netcodeintegrationtest-remove-extra-onnewclientcreated-call
Jun 8, 2022
Merged

fix: NetcodeIntegrationTest remove extra OnNewClientCreated call#2005
0xFA11 merged 2 commits intodevelopfrom
fix/netcodeintegrationtest-remove-extra-onnewclientcreated-call

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

This PR removes the extra call to OnNewClientCreated.

Changelog

None

Testing and Documentation

  • No tests have been added (existing tests verify the fix)

This removes the extra call to OnNewClientCreated.
adding a comment about the method.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 8, 2022 16:42
Copy link
Copy Markdown
Contributor

@JesseOlmer JesseOlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xFA11 0xFA11 merged commit 6d7c00e into develop Jun 8, 2022
@0xFA11 0xFA11 deleted the fix/netcodeintegrationtest-remove-extra-onnewclientcreated-call branch June 8, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants