Skip to content

fix: DestroyGameObject message changes updated for NetworkObject.NetworkHide - MTT-3552 (backport #1960)#1970

Closed
NoelStephensUnity wants to merge 2 commits intorelease/1.0.0from
fix/backport-MTT-3552-destroygameobject-message-revisit-fix-networkobject-networkhide
Closed

fix: DestroyGameObject message changes updated for NetworkObject.NetworkHide - MTT-3552 (backport #1960)#1970
NoelStephensUnity wants to merge 2 commits intorelease/1.0.0from
fix/backport-MTT-3552-destroygameobject-message-revisit-fix-networkobject-networkhide

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented May 16, 2022

This is a backport of #1960.
This requires #1968 to be merged before this gets merged (it will fail until #1968 is merged)

This fixes the issue introduced by PR-1898 that updated the DestroyGameObject to be able to "soft destroy" a NetworkObject.
This also adds additional NetworkShowHide integration test checks to make sure the GameObject on the client-side is indeed destroyed.

MTT-3552

Testing and Documentation

  • Includes integration test update for NetworkShowHideTests

MTT-3552
This fixes the issue with NetworkHide not being updated to changes in DestroyObjectMessage.
This updates the NetworkShowHideTests to verify the GameObject is indeed destroyed on the client side when hidden.
It also fixes a few other potential timing issues and cleaned up some of the code to leverage from more recent updates to NetcodeIntegrationTest.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 16, 2022 16:53
@NoelStephensUnity NoelStephensUnity marked this pull request as draft May 16, 2022 16:54
@0xFA11 0xFA11 closed this May 16, 2022
@0xFA11 0xFA11 deleted the fix/backport-MTT-3552-destroygameobject-message-revisit-fix-networkobject-networkhide branch May 16, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants