Skip to content

fix: DestroyGameObject message changes updated for NetworkObject.NetworkHide - MTT-3552#1960

Merged
NoelStephensUnity merged 2 commits intodevelopfrom
fix/destroygameobject-message-revisit-fix-networkobject-networkhide
May 11, 2022
Merged

fix: DestroyGameObject message changes updated for NetworkObject.NetworkHide - MTT-3552#1960
NoelStephensUnity merged 2 commits intodevelopfrom
fix/destroygameobject-message-revisit-fix-networkobject-networkhide

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

This fixes the issue introduced by PR-1898 that updated the DestroyGameObject to be able to "soft destroy" a NetworkObject.
This also adds additional NetworkShowHide integration test checks to make sure the GameObject on the client-side is indeed destroyed.

MTT-3552

Testing and Documentation

  • Includes integration test update for NetworkShowHideTests

MTT-3552
This fixes the issue with NetworkHide not being updated to changes in DestroyObjectMessage.
This updates the NetworkShowHideTests to verify the GameObject is indeed destroyed on the client side when hidden.
It also fixes a few other potential timing issues and cleaned up some of the code to leverage from more recent updates to NetcodeIntegrationTest.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 11, 2022 18:54
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 11, 2022 19:02
@NoelStephensUnity NoelStephensUnity merged commit 3b853e0 into develop May 11, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/destroygameobject-message-revisit-fix-networkobject-networkhide branch May 11, 2022 19:37
@NoelStephensUnity NoelStephensUnity restored the fix/destroygameobject-message-revisit-fix-networkobject-networkhide branch May 16, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants