fix: shutting down properly, when failing to StartHost or StartClient

[jeffreyrainy]

Shutting down properly, when failing to StartHost or StartClient. This allows the next attempt to not fail automatically.

MTT-3421

[simon-lemay-unity]

I'm not against this change, but won't the NetworkManager call the transport's Shutdown method if StartClient or StartServer fail? If it doesn't, shouldn't it?

[jeffreyrainy]

I'm not against this change, but won't the NetworkManager call the transport's Shutdown method if StartClient or StartServer fail? If it doesn't, shouldn't it?

Yes, it does, but it's not enough to allow re-hosting. It's two-layer. To host again, both the NetworkManager and the m_Driver must be in the right state. Each can individually error out.

[simon-lemay-unity]

Ah right, I see the issue. NetworkManager only calls the transport's Shutdown if IsListening is true. And that isn't the case when the transport's StartClient or StartServer have failed.