fix: NetworkList serialization sends the list values before the cached updates, to prevent duplicate application#1917
Merged
jeffreyrainy merged 2 commits intodevelopfrom Apr 29, 2022
Conversation
…d updates, to prevent duplicate application
Contributor
Author
|
The story here is that when user code modifies a NetworkList during OnNetworkSpawn (or other notifications) the NetworkList gets serialized while it has dirty events. So, the modified list is sent, and then the dirty events get sent at the next update. The client side applies the event, thus duplicating the list. The proper catch-all flow, to me, was to always serialize the list as it was before the dirty events came in, and trust them to be applied at the next update. |
jeffreyrainy
added a commit
that referenced
this pull request
May 4, 2022
…d updates, to prevent duplicate application (#1917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: NetworkList serialization sends the list values before the cached updates, to prevent duplicate application
MTT-3021
#1590