hotfix(maybe deprecate): eigensdk on Operator and Aggregator boot#1737
Closed
hotfix(maybe deprecate): eigensdk on Operator and Aggregator boot#1737
Conversation
PatStiles
approved these changes
Jan 13, 2025
Oppen
reviewed
Jan 14, 2025
Comment on lines
+45
to
+72
| // We build the V0.2.0-beta.1 clients | ||
| buildAllConfig := eigenClients.BuildAllConfig{ | ||
| EthHttpUrl: baseConfig.EthRpcUrl, | ||
| EthWsUrl: baseConfig.EthWsUrl, | ||
| RegistryCoordinatorAddr: baseConfig.AlignedLayerDeploymentConfig.AlignedLayerRegistryCoordinatorAddr.String(), | ||
| OperatorStateRetrieverAddr: baseConfig.AlignedLayerDeploymentConfig.AlignedLayerOperatorStateRetrieverAddr.String(), | ||
| AvsName: "AlignedLayer", | ||
| PromMetricsIpPortAddress: baseConfig.EigenMetricsIpPortAddress, | ||
| } | ||
| clients, err := eigenClients.BuildReadClients(buildAllConfig, baseConfig.Logger) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| chainReader := clients.AvsRegistryChainReader | ||
|
|
||
| avsServiceBindings, err := NewAvsServiceBindings(baseConfig.AlignedLayerDeploymentConfig.AlignedLayerServiceManagerAddr, baseConfig.AlignedLayerDeploymentConfig.AlignedLayerOperatorStateRetrieverAddr, baseConfig.EthRpcClient, baseConfig.EthRpcClientFallback, baseConfig.Logger) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| chainReader := clients.AvsRegistryChainReader | ||
| return &AvsReader{ | ||
| ChainReader: chainReader, | ||
| AvsContractBindings: avsServiceBindings, | ||
| AlignedLayerServiceManagerAddr: baseConfig.AlignedLayerDeploymentConfig.AlignedLayerServiceManagerAddr, | ||
| logger: baseConfig.Logger, | ||
| }, nil | ||
| } | ||
| chainReader := clients_v0113.AvsRegistryChainReader |
Contributor
There was a problem hiding this comment.
Maybe move this logic to a separate function.
Oppen
reviewed
Jan 14, 2025
| golang.org/x/crypto v0.22.0 | ||
| ) | ||
|
|
||
| replace github.com/Layr-Labs/eigensdk-go-v0.1.13 => github.com/Layr-Labs/eigensdk-go v0.1.13 |
Contributor
There was a problem hiding this comment.
We may want a comment explaining the dark magic at play.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
PR replaced by #1740
EigenSDK fix
Description
EigenSDK made a breaking change that stops Operators from restarting, and stops a potential Aggregator restart as well.
This PR imports both versions of the SDK, and tries first with the old one, then with the new one.
Type of change
Checklist
testnet, everything else tostaging