feat(telemetry): implement telemetry for aggregator#1077
Merged
Conversation
feat: CRUD for operators version
docs: update README
… creation (#1080) Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
This was referenced Sep 30, 2024
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator # Conflicts: # telemetry_api/config/dev.exs # telemetry_api/mix.exs # telemetry_api/mix.lock
…erator_tracker-in-elixir
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator
fix: store address and operator_id in lowercase
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator
…-in-elixir' into 1075-feattelemetry-implement-telemetry-for-aggregator # Conflicts: # telemetry_api/lib/telemetry_api_web/controllers/operator_controller.ex
Oppen
reviewed
Oct 4, 2024
Comment on lines
+34
to
+35
| client *http.Client | ||
| baseURL *url.URL |
Contributor
There was a problem hiding this comment.
Do these need to be pointers?
Contributor
There was a problem hiding this comment.
They didn't. Changed them!
Oppen
reviewed
Oct 4, 2024
Base automatically changed from
998-refactortracker-rewrite-operator_tracker-in-elixir
to
staging
October 4, 2024 18:34
uri-99
suggested changes
Oct 8, 2024
entropidelic
approved these changes
Oct 9, 2024
uri-99
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supersedes #949
The aggregator has to communicate to the telemetry_api using HTTP endpoints
The telemetry_api will handle traces creation
closes #1075
Tasks
How to Test
Tip
You will need a lot of terminals 😎
You should see traces like the following one