feat(tracker): update operators' version if they already exist

telemetry_api/lib/telemetry_api/operators.ex

@@ -24,18 +24,18 @@ defmodule TelemetryApi.Operators do
   @doc """
   Gets a single operator.
 
-  Raises `Ecto.NoResultsError` if the Operator does not exist.
-
   ## Examples
 
-      iex> get_operator!(123)
+      iex> get_operator("some_address"})
       %Operator{}
 
-      iex> get_operator!(456)
-      ** (Ecto.NoResultsError)
+      iex> get_operator("non_existent_address")
+      nil
 
   """
-  def get_operator!(id), do: Repo.get!(Operator, id)
+  def get_operator(address) do
+    Repo.get(Operator, address)
+  end
 
   @doc """
   Creates a operator.
@@ -51,11 +51,16 @@ defmodule TelemetryApi.Operators do
   """
   def create_operator(attrs \\ %{}) do
     # Get address from the signature
-    address = SignatureVerifier.get_address(attrs["version"], attrs["signature"])
+    address = "0x" <> SignatureVerifier.get_address(attrs["version"], attrs["signature"])
     attrs = Map.put(attrs, "address", address)
-    %Operator{}
+
+    # We handle updates here as there is no patch method available at the moment.
+    case Repo.get(Operator, address) do
+      nil -> %Operator{}
+      operator -> operator
+    end
     |> Operator.changeset(attrs)
-    |> Repo.insert()
+    |> Repo.insert_or_update()
   end
 
   @doc """

telemetry_api/lib/telemetry_api/operators/operator.ex

@@ -2,9 +2,9 @@ defmodule TelemetryApi.Operators.Operator do
   use Ecto.Schema
   import Ecto.Changeset
 
+  @primary_key {:address, :string, []}
   schema "operators" do
     field :version, :string
-    field :address, :string
 
     timestamps(type: :utc_datetime)
   end
@@ -16,3 +16,7 @@ defmodule TelemetryApi.Operators.Operator do
     |> validate_required([:address, :version])
   end
 end
+
+defimpl Phoenix.Param, for: TelemetryApi.Operators.Operator do
+  def to_param(%TelemetryApi.Operators.Operator{address: address}), do: address
+end

telemetry_api/lib/telemetry_api_web/controllers/operator_controller.ex

@@ -20,16 +20,24 @@ defmodule TelemetryApiWeb.OperatorController do
     end
   end
 
-  def show(conn, %{"id" => id}) do
-    operator = Operators.get_operator!(id)
-    render(conn, :show, operator: operator)
+  def show(conn, %{"id" => address}) do
+    case Operators.get_operator(address) do
+      %Operator{} = operator ->
+        render(conn, :show, operator: operator)
+
+      nil ->
+        conn
+        |> put_status(:not_found)
+        |> put_view(TelemetryApiWeb.ErrorJSON)
+        |> render("404.json", %{})
+    end
   end
 
-  # def update(conn, %{"id" => id, "operator" => operator_params}) do
-  #   operator = Operators.get_operator!(id)
-
+  # defp update(conn, operator, operator_params) do
   #   with {:ok, %Operator{} = operator} <- Operators.update_operator(operator, operator_params) do
-  #     render(conn, :show, operator: operator)
+  #     conn
+  #     |> put_status(:ok)
+  #     |> render(:show, operator: operator)
   #   end
   # end
 

telemetry_api/lib/telemetry_api_web/controllers/operator_json.ex

@@ -17,7 +17,6 @@ defmodule TelemetryApiWeb.OperatorJSON do
 
   defp data(%Operator{} = operator) do
     %{
-      id: operator.id,
       address: operator.address,
       version: operator.version
     }

telemetry_api/lib/telemetry_api_web/router.ex

@@ -10,6 +10,11 @@ defmodule TelemetryApiWeb.Router do
     resources "/operators", OperatorController, only: [:index, :show, :create]
   end
 
+  scope "/versions", TelemetryApiWeb do
+    pipe_through :api
+    resources "/", OperatorController, only: [:index, :show, :create]
+  end
+
   # Enable LiveDashboard in development
   if Application.compile_env(:telemetry_api, :dev_routes) do
     # If you want to use the LiveDashboard in production, you should put

telemetry_api/priv/repo/migrations/20240917212329_create_operators.exs

@@ -2,11 +2,13 @@ defmodule TelemetryApi.Repo.Migrations.CreateOperators do
   use Ecto.Migration
 
   def change do
-    create table(:operators) do
-      add :address, :string
+    create table(:operators, primary_key: false) do
+      add :address, :string, primary_key: true
       add :version, :string
 
       timestamps(type: :utc_datetime)
     end
+
+    create unique_index(:operators, [:address])
   end
 end