Skip to content

docs: update options for next#3423

Merged
snitin315 merged 2 commits intonextfrom
update-docs-next
Sep 26, 2022
Merged

docs: update options for next#3423
snitin315 merged 2 commits intonextfrom
update-docs-next

Conversation

@snitin315
Copy link
Copy Markdown
Member

@snitin315 snitin315 commented Sep 24, 2022

What kind of change does this PR introduce?
docs.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
Yes.

Summary

Fix #3365

All breaking changes related to commands and options are done we can update docs now.

  • Update docs.
  • Remove SERVE-OPTIONS-v3.md

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner September 24, 2022 11:15
@snitin315 snitin315 changed the base branch from master to next September 24, 2022 11:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2022

Codecov Report

Merging #3423 (e103a94) into next (ee91c94) will decrease coverage by 3.29%.
The diff coverage is 91.30%.

❗ Current head e103a94 differs from pull request most recent head 5241477. Consider uploading reports for the commit 5241477 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3423      +/-   ##
==========================================
- Coverage   94.91%   91.61%   -3.30%     
==========================================
  Files          30       22       -8     
  Lines        1690     1587     -103     
  Branches      492      447      -45     
==========================================
- Hits         1604     1454     -150     
- Misses         86      133      +47     
Impacted Files Coverage Δ
packages/generators/src/handlers/react.ts 56.81% <56.81%> (ø)
packages/webpack-cli/bin/cli.js 85.71% <66.66%> (+19.04%) ⬆️
packages/generators/src/index.ts 79.54% <75.67%> (-20.46%) ⬇️
packages/serve/src/index.ts 78.94% <78.76%> (-5.33%) ⬇️
...ges/webpack-cli/src/utils/dynamic-import-loader.ts 83.33% <83.33%> (ø)
packages/generators/src/loader-generator.ts 91.66% <85.71%> (ø)
packages/generators/src/init-generator.ts 87.50% <86.11%> (-10.46%) ⬇️
packages/generators/src/addon-generator.ts 92.72% <92.15%> (+0.13%) ⬆️
packages/webpack-cli/src/webpack-cli.ts 93.45% <93.45%> (ø)
packages/generators/src/utils/helpers.ts 95.00% <93.75%> (+10.00%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1524ec2...5241477. Read the comment docs.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some descriptions were changed, I think we should improve descriptions on webpack side, anyway feel free to merge

@snitin315 snitin315 merged commit f304ab2 into next Sep 26, 2022
@snitin315 snitin315 deleted the update-docs-next branch September 26, 2022 04:26
snitin315 added a commit that referenced this pull request Oct 8, 2022
snitin315 added a commit that referenced this pull request Oct 22, 2022
snitin315 added a commit that referenced this pull request Nov 6, 2022
snitin315 added a commit that referenced this pull request Nov 8, 2022
alexander-akait pushed a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants