fix: add gracefull shutdown when clicking stop button for proxy server#4
Merged
therealaleph merged 3 commits intotherealaleph:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
Author
|
sorry if cargo fmt added more changes than required and i know its annoying to review. |
therealaleph
added a commit
that referenced
this pull request
Apr 25, 2026
Thanks @v4g4b0nd-0x76 — proper listener teardown on Stop is exactly what was needed. The 2-second grace window + force-abort fallback is a clean pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix graceful shutdown for GUI Stop button
Problem:
Root Cause:
GUI was immediately aborting the proxy task right after sending shutdown signal, killing it before it could clean up resources.
Solution: