Add support for optional params#631
Merged
ryansolid merged 1 commit intosolidjs:mainfrom Jan 9, 2023
Merged
Conversation
Member
|
Thanks. This has been overdue. I was thinking about it just the other day. |
Contributor
|
Hi @ryansolid somewhat related to this PR just in case you didn’t see it: solidjs/solid-router#227 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for optional params to the file system routing.
The syntax chosen is
[[param]], the first set of square brackets indicate that it is a parameter and the second set indicate that it is optional.This syntax was chosen because
?is not a valid character in filenames on Windows.Usage example: