Conversation
* added sandpack linter and installed latest sandpacl * integrate eslint into Sandpack * Format the linting errors, disable preview on lint error, have only two react hooks * fixes build * split eslint-integration * fix tooltip text color, error rename to 'Lint Error', show single lint error * NIT * Just enable it * Delete eslint.md Co-authored-by: Strek <ssharishkumar@gmail.com> Co-authored-by: dan <dan.abramov@gmail.com>
* add new bundle for testing * add timer * update url * update bundler version * Remove temporary code * Fix lint * why? * testing bundler url * uncaught exception handling * catch global errors on new bundler * Try latest bundler Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* [Beta] Lazy-load linter code * Split utils into separate files
* [Beta] Update Next and React * Fix types
* [Beta] Enable Selective Hydration in more places * Fix typo
* upgrade react types * fix type errors after upgrade
The Text "Click me" in the button confuses first-time users because it forces them to actually click on the button in the live demo but it does nothing. By changing the text, we can control the user behavior as they don't expect anything on that click.
* add loading indicator to sidebar links * fix clicking on same route whould show indicator * maybe final? * handle routeChangeError as well as cleaning up timeout * clearing timeout before creating one instead of routeChangeError * rm unused * add license header * Update usePendingRoute.ts Co-authored-by: dan <dan.abramov@gmail.com>
* fix(eslint): messages severity * .
This reverts commit 2d46af6.
These are now pointing at a different event, I've left/updated the video links though for posterity
* add remix conf * add remix conf 2023
* [Beta] Optimize some performance * Unnecessary image optimization * Unused optimizeFonts
* fix(navigation): ui tweak * revert border color
* added code for sandpack console * add log * added console for older bundle * Revert "[beta] Sandpack - new bundler (#4458)" This reverts commit 3ab1245. * adds proper console and removes new bundle * modify styles * remove unwanted code * nit * fix types (#4677) * update console * little nits * remove unwanted code changes * update bundler URL * use `message.firstLoad` for clearing console * use `refresh` event to clear logs as well (used when going away and coming back to sandpack) * remove padding for code blocks inside console * small UI revamps * change p to div since the sandpack comes inside the p, add try catch and a try catch for the catch again * tweaks * Fixes * Reset unrelated changes * tweaks * fix * fixes * oops * Fix * fix Co-authored-by: Danilo Woznica <danilowoz@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Size ChangesDetails📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Hundred Ninety Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
bugtender
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 6d96542
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.