Typechecking with Proptypes translated#98
Merged
vldmrkl merged 8 commits intoreactjs:masterfrom Apr 8, 2019
Merged
Conversation
92 tasks
vburlai
commented
Apr 6, 2019
| optionalArray: PropTypes.array, | ||
| optionalBool: PropTypes.bool, | ||
| optionalFunc: PropTypes.func, | ||
| optionalFunc: PropTypes.func, // наприклад, приймає функцію або відсутнє значення |
Contributor
Author
There was a problem hiding this comment.
should I somehow give hints about meanings of variable names?
Contributor
There was a problem hiding this comment.
optionalFunc => опціональна функція, про що тут гадати?:)
|
Deploy preview for uk-reactjs ready! Built with commit 34506fc |
oleksii-polovyi
requested changes
Apr 7, 2019
Member
oleksii-polovyi
left a comment
There was a problem hiding this comment.
Good start 😃
Please follow up with the suggestions below.
mihilbabin
suggested changes
Apr 8, 2019
mihilbabin
approved these changes
Apr 8, 2019
vldmrkl
requested changes
Apr 8, 2019
Member
vldmrkl
left a comment
There was a problem hiding this comment.
Дякую за переклад 🙌
Треба трошки виправити, і можна буде заливати в мастер 😀
Co-Authored-By: vburlai <vitaly.burlai@gmail.com>
Contributor
Author
|
Hi @klymenkoo and @ApolllonDev, Thank you for reviewing. |
Member
|
@vburlai Awesome 🔥🔥🔥 |
vldmrkl
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typechecking with Proptypestranslated