Skip to content

Added translation for rendering elements and code snippets#2

Merged
vldmrkl merged 3 commits intoreactjs:masterfrom
mihilbabin:master
Feb 12, 2019
Merged

Added translation for rendering elements and code snippets#2
vldmrkl merged 3 commits intoreactjs:masterfrom
mihilbabin:master

Conversation

@mihilbabin
Copy link
Copy Markdown
Contributor

Rendering Elements section translated

@vldmrkl vldmrkl requested review from tesseralis and vldmrkl and removed request for tesseralis February 11, 2019 16:51
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
@reactjs reactjs deleted a comment from oleksii-polovyi Feb 11, 2019
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread examples/rendering-elements/update-rendered-element.js Outdated
Comment thread examples/rendering-elements/render-an-element.js Outdated
Copy link
Copy Markdown
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Please review some minor suggestions proposed above.

Copy link
Copy Markdown
Contributor

@westanvv westanvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translation. But I want to suggest some changes

Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Copy link
Copy Markdown
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за PR! Дуже гарна робота, лише декілька дрібніх коригувань, та можна приймати ваш PR 😀

Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
Comment thread content/docs/rendering-elements.md Outdated
@vldmrkl
Copy link
Copy Markdown
Member

vldmrkl commented Feb 12, 2019

@mihilbabin Гарна робота! Дякую за Ваш внесок 👏👏👏

@vldmrkl vldmrkl merged commit b2845fe into reactjs:master Feb 12, 2019
react-translations-bot pushed a commit that referenced this pull request Oct 10, 2022
* Added documentation for React.createFactory

* Update beta/src/content/apis/react/createFactory.md

Co-authored-by: Strek <ssharishkumar@gmail.com>

* minor editorial updates (#2)

* Update createFactory.md

* Update createFactory.md

* edits

Co-authored-by: Strek <ssharishkumar@gmail.com>
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
rickhanlonii added a commit that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants