Components and Props#10
Merged
vldmrkl merged 4 commits intoreactjs:masterfrom Feb 19, 2019
Hidden character warning
The head ref may contain hidden characters: "\u0441omponents-and-props"
Merged
Conversation
92 tasks
mihilbabin
reviewed
Feb 14, 2019
Contributor
|
Можливо, є сенс словосполучення |
vldmrkl
requested changes
Feb 14, 2019
Member
vldmrkl
left a comment
There was a problem hiding this comment.
Гарний початок! Кілька дрібних виправлень, а загалом дуже добре.
liashchynskyi
suggested changes
Feb 18, 2019
vldmrkl
requested changes
Feb 18, 2019
| 4. React DOM efficiently updates the DOM to match `<h1>Hello, Sara</h1>`. | ||
| 1. Ми викликаємо `ReactDOM.render()` з елементом `<Welcome name="Василина" />`. | ||
| 2. React викликає компонент `Welcome` з пропсом `{name: 'Василина'}`. | ||
| 3. `Welcome` компонент повертає елемент `<h1>Привіт, Василина</h1>`. |
Member
There was a problem hiding this comment.
Повинен використовуватися кличний відмінок: Привіт, Василино
Contributor
Author
There was a problem hiding this comment.
Я б не змінював, адже name передбачає ім'я в називному відмінку. А відмінювання - це вже логіка відображення. Що вирішуємо? Змінити?
Member
There was a problem hiding this comment.
@westanvv гарний аргумент. Залишаємо тоді у називному відмінку.
| 1. Ми викликаємо `ReactDOM.render()` з елементом `<Welcome name="Василина" />`. | ||
| 2. React викликає компонент `Welcome` з пропсом `{name: 'Василина'}`. | ||
| 3. `Welcome` компонент повертає елемент `<h1>Привіт, Василина</h1>`. | ||
| 4. React DOM ефективно оновлює DOM для отримання `<h1>Привіт, Василина</h1>`. |
Member
There was a problem hiding this comment.
Повинен використовуватися кличний відмінок: Привіт, Василино
vldmrkl
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translation for Components and Props page.