Skip to content

Translate ../../library/string.rst:420-430#712

Merged
mattwang44 merged 2 commits intopython:event-1125from
heyimkaijoe:string-translate-420-430
Dec 27, 2023
Merged

Translate ../../library/string.rst:420-430#712
mattwang44 merged 2 commits intopython:event-1125from
heyimkaijoe:string-translate-420-430

Conversation

@heyimkaijoe
Copy link
Copy Markdown
Contributor

translate ../../library/string.rst:420 to ../../library/string.rst:430

Comment thread library/string.po Outdated
@heyimkaijoe heyimkaijoe requested a review from ken71301 November 25, 2023 07:40
Copy link
Copy Markdown
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread library/string.po Outdated
Comment thread library/string.po Outdated
Comment thread library/string.po Outdated
Comment thread library/string.po Outdated
@mattwang44
Copy link
Copy Markdown
Collaborator

rebase

Copy link
Copy Markdown
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @mattwang44 's review, there are still some words that need to be fix or reconsider, thanks.
@heyimkaijoe would you fix this pr?

Copy link
Copy Markdown
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwang44 mattwang44 merged commit 9dc5132 into python:event-1125 Dec 27, 2023
mattwang44 added a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
mattwang44 added a commit that referenced this pull request Jan 27, 2024
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants